Skip to content

[Remove] unused patch utility exports - #441

Open
juanmaguitar wants to merge 1 commit into
trunkfrom
juanmaguitar/cleanup-432
Open

[Remove] unused patch utility exports#441
juanmaguitar wants to merge 1 commit into
trunkfrom
juanmaguitar/cleanup-432

Conversation

@juanmaguitar

Copy link
Copy Markdown
Collaborator

Why

The patch utility modules exposed two internal helpers that no runtime consumer imports. Keeping their implementations private reduces the accidental module API without changing patch selection or provenance behavior.

What changes

Removes prDateMs and SHORT_OID_LENGTH from their respective module.exports objects. Their module-private declarations and every runtime-facing export remain unchanged.

How to test this

Platforms: any — this has no user-visible surface.

Starting state:

  1. Check out this branch with dependencies installed.
  2. Run the validation commands below.

Expected result:

  1. node --test tests/unit/latest-patch.test.cjs tests/unit/patch-provenance.test.cjs passes.
  2. npm run lint and npm test pass.

What must not have happened:

No patch ranking, provenance header, filename, or event-validation behavior changes. No files outside the two utility modules are committed.

Risks and limitations

This intentionally removes only exports confirmed to have no repository consumer; consumers retain the same runtime behavior. Fresh self-review: 0 [fix here] · 0 [follow-up].

Related

Fixes #432


Design decisions and alternatives considered

Kept declarations module-private rather than deleting them because both helpers remain used internally. Kept exports exercised by current unit tests and runtime call sites public.

Review outcome (required — see AGENTS.md)

0 [fix here] · 0 [follow-up] — no findings across architecture, security, performance, cross-platform, or tests.

Implementation notes

Validation passed: focused utility tests (35 tests), npm run lint, and npm test (1,258 tests).

@juanmaguitar juanmaguitar added the audit-code Follow-up work from the codebase audit label Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9b3e9c73-506d-49f8-a971-56d85fbef9fd

📥 Commits

Reviewing files that changed from the base of the PR and between 413c2a9 and 32e0882.

📒 Files selected for processing (2)
  • src/latest-patch.cjs
  • src/patch-provenance.cjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@juanmaguitar

Copy link
Copy Markdown
Collaborator Author

@coderabbitai rate limit

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Your plan includes PR reviews subject to rate limits. Reviews are available now.

@juanmaguitar

Copy link
Copy Markdown
Collaborator Author

@coderabbitai reviews remaining

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Your plan includes PR reviews subject to rate limits. Reviews are available now.

@juanmaguitar

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-code Follow-up work from the codebase audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused exports from patch utilities

1 participant