[Remove] unused patch utility exports - #441
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai rate limit |
|
Your plan includes PR reviews subject to rate limits. Reviews are available now. |
|
@coderabbitai reviews remaining |
|
Your plan includes PR reviews subject to rate limits. Reviews are available now. |
|
@coderabbitai review |
|
Why
The patch utility modules exposed two internal helpers that no runtime consumer imports. Keeping their implementations private reduces the accidental module API without changing patch selection or provenance behavior.
What changes
Removes
prDateMsandSHORT_OID_LENGTHfrom their respectivemodule.exportsobjects. Their module-private declarations and every runtime-facing export remain unchanged.How to test this
Platforms: any — this has no user-visible surface.
Starting state:
Expected result:
node --test tests/unit/latest-patch.test.cjs tests/unit/patch-provenance.test.cjspasses.npm run lintandnpm testpass.What must not have happened:
No patch ranking, provenance header, filename, or event-validation behavior changes. No files outside the two utility modules are committed.
Risks and limitations
This intentionally removes only exports confirmed to have no repository consumer; consumers retain the same runtime behavior. Fresh self-review: 0 [fix here] · 0 [follow-up].
Related
Fixes #432
Design decisions and alternatives considered
Kept declarations module-private rather than deleting them because both helpers remain used internally. Kept exports exercised by current unit tests and runtime call sites public.
Review outcome (required — see AGENTS.md)
0 [fix here] · 0 [follow-up] — no findings across architecture, security, performance, cross-platform, or tests.
Implementation notes
Validation passed: focused utility tests (35 tests),
npm run lint, andnpm test(1,258 tests).