[Remove] unused Git and logging exports - #439
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
Why
git-progress.cjsandsafe-log.jsexposed implementation constants that no caller imports. Keeping their public API limited to consumed helpers prevents consumers from depending on internal details without changing behavior.What changes
Removes
PROGRESS_LINE,CONTROL_CHARACTERS, andMAX_DESCRIPTION_LENGTHfrom their respective CommonJS export objects. The constants remain module-private and the existing exported behavior, includingparseProgressLines, is unchanged.How to test this
No user-visible surface changed; this is an API-surface cleanup, so manual app testing is not applicable.
Starting state: A checkout with dependencies installed.
npm run lint; it exits successfully.npm test; all tests pass, includingtests/unit/git-progress.test.cjsand logging refusal behavior exercised by the suite.What must not have happened: Git progress parsing and bounded, one-line refusal logging must continue to behave identically; no production consumer may need the removed internal exports.
Platforms: any — this only narrows JavaScript module exports.
Risks and limitations
Low risk: this is a deliberate breaking change only for unsupported, unconsumed exports. No user-facing behavior changed and no manual UI path applies.
Related
Fixes #431
Design decisions and alternatives considered
Kept the constants in their original modules rather than deleting or inlining them, preserving implementation behavior and readability. Retained
parseProgressLinesbecause its dedicated unit test imports it.Review outcome (required — see AGENTS.md)
0 [fix here] · 0 [follow-up] — none found. The review checked architecture, security, performance, cross-platform behavior, and test coverage against the two-file diff; no invariants are affected.
Implementation notes
Validation:
node --test tests/unit/git-progress.test.cjs,npm run lint, andnpm test(1,258 passing). The worktree has a pre-existing unrelatedpackage-lock.jsonmodification, excluded from this commit and PR.