Skip to content

[Remove] unused Git and logging exports - #439

Open
juanmaguitar wants to merge 1 commit into
trunkfrom
juanmaguitar/cleanup-431
Open

[Remove] unused Git and logging exports#439
juanmaguitar wants to merge 1 commit into
trunkfrom
juanmaguitar/cleanup-431

Conversation

@juanmaguitar

Copy link
Copy Markdown
Collaborator

Why

git-progress.cjs and safe-log.js exposed implementation constants that no caller imports. Keeping their public API limited to consumed helpers prevents consumers from depending on internal details without changing behavior.

What changes

Removes PROGRESS_LINE, CONTROL_CHARACTERS, and MAX_DESCRIPTION_LENGTH from their respective CommonJS export objects. The constants remain module-private and the existing exported behavior, including parseProgressLines, is unchanged.

How to test this

No user-visible surface changed; this is an API-surface cleanup, so manual app testing is not applicable.

Starting state: A checkout with dependencies installed.

  1. Run npm run lint; it exits successfully.
  2. Run npm test; all tests pass, including tests/unit/git-progress.test.cjs and logging refusal behavior exercised by the suite.

What must not have happened: Git progress parsing and bounded, one-line refusal logging must continue to behave identically; no production consumer may need the removed internal exports.

Platforms: any — this only narrows JavaScript module exports.

Risks and limitations

Low risk: this is a deliberate breaking change only for unsupported, unconsumed exports. No user-facing behavior changed and no manual UI path applies.

Related

Fixes #431


Design decisions and alternatives considered

Kept the constants in their original modules rather than deleting or inlining them, preserving implementation behavior and readability. Retained parseProgressLines because its dedicated unit test imports it.

Review outcome (required — see AGENTS.md)

0 [fix here] · 0 [follow-up] — none found. The review checked architecture, security, performance, cross-platform behavior, and test coverage against the two-file diff; no invariants are affected.

Implementation notes

Validation: node --test tests/unit/git-progress.test.cjs, npm run lint, and npm test (1,258 passing). The worktree has a pre-existing unrelated package-lock.json modification, excluded from this commit and PR.

@juanmaguitar juanmaguitar added the audit-code Follow-up work from the codebase audit label Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4e47300f-d2d8-4690-8023-7ae7db4bb314

📥 Commits

Reviewing files that changed from the base of the PR and between 413c2a9 and dbd1699.

📒 Files selected for processing (2)
  • src/git-progress.cjs
  • src/safe-log.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@juanmaguitar

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-code Follow-up work from the codebase audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused exports from Git progress and safe logging

1 participant