Skip to content

[Remove] brittle renderer source-text tests - #437

Open
juanmaguitar wants to merge 1 commit into
trunkfrom
juanmaguitar/cleanup-425
Open

[Remove] brittle renderer source-text tests#437
juanmaguitar wants to merge 1 commit into
trunkfrom
juanmaguitar/cleanup-425

Conversation

@juanmaguitar

Copy link
Copy Markdown
Collaborator

Why

The renderer source-text tests inspect src/renderer/index.jsx implementation details rather than observable behavior. They break when harmless component refactors change layout or effect declaration structure, while the extracted pure renderer modules already provide stable behavioral coverage.

What changes

Remove only tests that read src/renderer/index.jsx as raw text, including the ordering-only suite whose two tests are entirely source inspections. Keep the pure-module notice and refusal tests; production code and unrelated tests are unchanged.

How to test this

Platforms: any — this is unit-test-only maintenance with no user-visible surface.

Starting state:

  1. Check out this PR branch.
  2. Run node --test tests/unit/ticket-trunk-notice.test.cjs tests/unit/trac-ticket-scrape-ordering.test.cjs tests/unit/legacy-site.test.cjs.

Expected result: the retained behavioral tests pass; the deleted ordering test file is no longer discovered.

What must not have happened:

No production files or renderer behavior changed, and the pure-module coverage for ticket-trunk and legacy-site notices remains.

Risks and limitations

No user-visible behavior changed. This deliberately removes source-layout coverage for the ticket-card wiring and scrape-effect ordering; those assertions were brittle and cannot exercise index.jsx behavior without a DOM harness.

Related

Fixes #425


Design decisions and alternatives considered

Kept the behavior tests for ticket-trunk-notice.cjs and legacy-site.cjs, which load as pure modules. Did not introduce a DOM harness or move renderer behavior solely to preserve tests, because the issue scope is removal of raw-source inspections.

Review outcome (required — see AGENTS.md)

0 [fix here] · 0 [follow-up] — independent five-dimension self-review found no findings. npm run lint and npm test both pass.

Implementation notes

Focused retained-test command, npm run lint, and npm test passed locally (1,254 tests).

@juanmaguitar juanmaguitar added the audit-code Follow-up work from the codebase audit label Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 645aa010-cf68-4ef0-ab82-d1e735064b54

📥 Commits

Reviewing files that changed from the base of the PR and between fd83488 and 71da768.

📒 Files selected for processing (3)
  • tests/unit/legacy-site.test.cjs
  • tests/unit/ticket-trunk-notice.test.cjs
  • tests/unit/trac-ticket-scrape-ordering.test.cjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@juanmaguitar

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-code Follow-up work from the codebase audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove brittle source-text tests for ticket notices and scrape ordering

1 participant