Skip to content

[Remove] terminal-hint visibility wrapper - #435

Open
juanmaguitar wants to merge 1 commit into
trunkfrom
juanmaguitar/cleanup-427
Open

[Remove] terminal-hint visibility wrapper#435
juanmaguitar wants to merge 1 commit into
trunkfrom
juanmaguitar/cleanup-427

Conversation

@juanmaguitar

Copy link
Copy Markdown
Collaborator

Why

shouldShowTerminalHints() only wrapped Boolean(hasBuilt) at one renderer call site, creating a test-only abstraction rather than a reusable decision.

What changes

  • Inline the existing boolean conversion in the renderer.
  • Remove the visibility wrapper and its truthiness-only tests.
  • Keep computeTerminalBusy() and its multi-state coverage unchanged.

How to test this

No user-visible surface changes. Run:

npm run lint
npm test

Expected: both commands pass; terminal hints remain hidden until a site has built.

Risks and limitations

Low risk: this preserves the exact existing boolean conversion at its sole call site.

Review outcome

0 [fix here] · 0 [follow-up]. The branch passed git diff --check, npm run lint, and npm test (1,256 tests).

Related

Fixes #427

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 58c93168-0e38-4233-9ec4-996734b7d8b9

📥 Commits

Reviewing files that changed from the base of the PR and between fd83488 and 7a40fcf.

📒 Files selected for processing (3)
  • src/renderer/index.jsx
  • src/renderer/terminal-hints.cjs
  • tests/unit/terminal-hints.test.cjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@juanmaguitar juanmaguitar added the audit-code Follow-up work from the codebase audit label Sep 10, 2026
@juanmaguitar

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-code Follow-up work from the codebase audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline terminal-hint visibility predicate

1 participant