[Remove] terminal-hint visibility wrapper - #435
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
Why
shouldShowTerminalHints()only wrappedBoolean(hasBuilt)at one renderer call site, creating a test-only abstraction rather than a reusable decision.What changes
computeTerminalBusy()and its multi-state coverage unchanged.How to test this
No user-visible surface changes. Run:
npm run lint npm testExpected: both commands pass; terminal hints remain hidden until a site has built.
Risks and limitations
Low risk: this preserves the exact existing boolean conversion at its sole call site.
Review outcome
0 [fix here] · 0 [follow-up]. The branch passed
git diff --check,npm run lint, andnpm test(1,256 tests).Related
Fixes #427