Repository navigation
Release: stable prompt-cache prefix and keys, token usage metrics #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4d33915
fix(llm): keep stable instructions first and send a stable prompt cac…
WilliamAGH 6fa1deb
fix(llm): keep JSON calls reasoning-free and record only reported tok…
WilliamAGH fa6cac5
fix(llm): record token usage without widening the streaming service's…
WilliamAGH eb064f1
test(embedding): report the actual failure message when the 401 surfa…
WilliamAGH 2e9c045
build(docker): pull base images through the fleet Docker Hub mirror
WilliamAGH 2e61035
build(frontend): expect the mirrored node base image in the node-vers…
WilliamAGH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/main/java/com/williamcallahan/javachat/domain/prompt/CompletionPrompt.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.williamcallahan.javachat.domain.prompt; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** Separates reusable task instructions from the current completion's untrusted input. */ | ||
| public record CompletionPrompt(String instructions, String input) { | ||
| /** Requires both boundary fields so instruction omission is explicit. */ | ||
| public CompletionPrompt { | ||
| Objects.requireNonNull(instructions, "instructions"); | ||
| Objects.requireNonNull(input, "input"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Do not count local admission deadlines as provider attempts.
If a batch request expires while waiting for a concurrency permit,
OpenAiCompatibleEmbeddingClient.gatewayDeadlineFailure()creates this exception before dispatch. This default returnstrue, soEmbeddingBatchEmbedder.embedWithRetry()consumes one of its three provider attempts. With a configured per-request timeout shorter than the ten-minute batch deadline, sustained permit contention can exhaust those attempts while no request from that batch reaches the provider. Mark pre-dispatch deadline failures as not provider-contacted; keep dispatched request timeouts classified separately.🤖 Prompt for AI Agents