fix: one PERSON caller per test file, not two - #87
Merged
Conversation
F5 (#83) and R2 (#86) repaired the same F4 breakage in parallel and landed minutes apart. Both added a `const PERSON: Caller` to `digest-arrival`, `digest` and `webhook`; the merge was textually clean and took both, so main has been failing on `TS2451: Cannot redeclare block-scoped variable 'PERSON'` since 96964f9. R2's declarations are kept — each says what the caller is for in that file's own terms, where F5's was one line repeated three times. F5's duplicates are removed. No other difference between the two repairs: the values are identical. 1241 tests pass, lint, typecheck and build are clean.
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been red since 96964f9 with:What happened
F4 (#82) branched from
95b0cc0, before S7 merged atf37b156, so itsactor→by: Callersweep never saw three of S7's test files. That leftmainred, and F5 (#83) and R2 (#86) both noticed and both fixed it,minutes apart. Each added a
const PERSON: Callerto the same three files.Neither merge conflicted, because the declarations sit in different places in
each file — so git took both, and the result does not compile.
What this does
Keeps R2's declarations and removes F5's. R2's say what the caller is for in
each file's own terms; F5's was the same line three times. The values are
identical, so there is no behavioural choice being made here — only which
comment survives.
Nothing else differed between the two repairs.
Verify
lintclean ·typecheckclean · 1241/1241 tests ·buildclean.