Skip to content

Remove logged-out AJAX hooks #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajaydsouza merged 2 commits into from
Nov 2, 2026
Merged

Remove logged-out AJAX hooks #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a1e43
Remove logged-out AJAX hooks from the settings search handlers
ajaydsouza Nov 2, 2026
270b6c0
Only accept post IDs the saving user can read
ajaydsouza Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion class-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public function __construct() {
Hook_Registry::add_filter( self::$prefix . '_settings_sanitize', array( $this, 'change_settings_on_save' ), 99 );
Hook_Registry::add_action( 'admin_menu', array( $this, 'redirect_on_save' ) );

Hook_Registry::add_action( 'wp_ajax_nopriv_' . self::$prefix . '_taxonomy_search_tom_select', array( __CLASS__, 'taxonomy_search_tom_select' ) );
Hook_Registry::add_action( 'wp_ajax_' . self::$prefix . '_taxonomy_search_tom_select', array( __CLASS__, 'taxonomy_search_tom_select' ) );
}

Expand Down
3 changes: 2 additions & 1 deletion settings/class-settings-sanitize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ public function sanitize_postids_field( $value ) {
$ids = array_filter( array_map( 'absint', explode( ',', sanitize_text_field( wp_unslash( $value ) ) ) ) );

foreach ( $ids as $key => $value ) {
if ( false === get_post_status( $value ) ) {
// Drop missing posts, and posts the saving user cannot read (CLI and cron have no user).
if ( false === get_post_status( $value ) || ( is_user_logged_in() && ! current_user_can( 'read_post', $value ) ) ) {
unset( $ids[ $key ] );
}
}
Expand Down
Loading