Service worker preload support by camillobruni · Pull Request #540 · WebKit/Speedometer

camillobruni · 2026-06-10T15:42:05Z

No description provided.

netlify · 2026-06-10T16:30:16Z

✅ Deploy Preview for webkit-speedometer-preview ready!

Name	Link
🔨 Latest commit	`6a6fe03`
🔍 Latest deploy log	https://app.netlify.com/projects/webkit-speedometer-preview/deploys/6a2985d153150400088ffa05
😎 Deploy Preview	https://deploy-preview-540--webkit-speedometer-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-06-10T16:30:24Z

✅ Deploy Preview for webkit-speedometer-preview ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`068673d`
🔍 Latest deploy log	https://app.netlify.com/projects/webkit-speedometer-preview/deploys/6af7443eed510c3fe48514bc
😎 Deploy Preview	https://deploy-preview-540--webkit-speedometer-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

# Conflicts: # experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/test-invoker.mjs # experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/test-runner.mjs # resources/suite-runner.mjs # suites-experimental/javascript-wc-indexeddb/dist/resources.txt # suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/step-runner.mjs # suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/step-scheduler.mjs # suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/test-invoker.mjs # suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/test-runner.mjs # suites-experimental/responsive-design/dist/resources.txt # suites-experimental/suites.mjs # suites-experimental/todomvc-dart-jaspr/dist/out-dart2js-O4/resources.txt # suites-experimental/todomvc-dart-jaspr/dist/out-dart2wasm-O2/resources.txt # suites-experimental/todomvc-localstorage/dist/base.css # suites-experimental/todomvc-localstorage/dist/index.css # suites-experimental/todomvc-localstorage/dist/resources.txt # suites-experimental/todomvc-localstorage/src/resources.txt # suites/charts/dist/resources.txt # suites/default-suites.mjs # suites/editors/dist/resources.txt # suites/newssite/news-next/dist/resources.txt # suites/newssite/news-next/public/resources.txt # suites/react-stockcharts/build/resources.txt # suites/todomvc/architecture-examples/angular-complex/dist/resources.txt # suites/todomvc/architecture-examples/angular/dist/resources.txt # suites/todomvc/architecture-examples/backbone-complex/dist/resources.txt # suites/todomvc/architecture-examples/backbone/dist/resources.txt # suites/todomvc/architecture-examples/jquery-complex/dist/resources.txt # suites/todomvc/architecture-examples/jquery/dist/resources.txt # suites/todomvc/architecture-examples/lit-complex/dist/resources.txt # suites/todomvc/architecture-examples/lit/dist/resources.txt # suites/todomvc/architecture-examples/preact-complex/dist/resources.txt # suites/todomvc/architecture-examples/preact/dist/resources.txt # suites/todomvc/architecture-examples/react-complex/dist/resources.txt # suites/todomvc/architecture-examples/react-redux-complex/dist/resources.txt # suites/todomvc/architecture-examples/react-redux/dist/resources.txt # suites/todomvc/architecture-examples/react/dist/resources.txt # suites/todomvc/architecture-examples/svelte-complex/dist/resources.txt # suites/todomvc/architecture-examples/svelte/dist/resources.txt # suites/todomvc/architecture-examples/vue-complex/dist/resources.txt # suites/todomvc/architecture-examples/vue/dist/resources.txt # suites/todomvc/big-dom-generator/dist/resources.txt # suites/todomvc/todomvc-css/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-es5-complex/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-es6-webpack-complex/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-es6-webpack/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-web-components-complex/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-web-components/dist/resources.txt # tests/run-end2end.mjs

This fixes a race condition where SpeedometerReady would fire while _preloadResources was still in flight asynchronously. That caused the test runner to simultaneously invoke benchmarkClient.start(), leading to concurrent preloads that randomly caused the PRELOAD_SUITES message to resolve a STOP_PRELOADING promise incorrectly on slower browsers.

canova

Thanks a lot for working on this! I left some comments to the issues that I found in my first review iteration, so not a comprehensive review yet. Please let me know what you think!

One issue that I noticed while checking the deploy preview link is that the "Use service worker for resource preloading" checkbox inside the developer mode doesn't work correctly. For example I go to https://deploy-preview-540--webkit-speedometer-preview.netlify.app/?developerMode=true and check the "Use service worker for resource preloading" checkbox. And it still doesn't do any preloading step when the benchmark is started. Then I refresh the page (now that it has &preload=true in the url), and try again and it works then.

Also, I think it would be great to write a small explanation at the PR description about the problem this PR is solving.

And also, I'm not entirely sure about the commit standards of this repo exactly, but it would be a great if you can squash the fx / cleanup / pre-format commits before merging.

canova · 2026-10-20T14:59:27Z

+        .trim()
+        .split("\n")
+        .map((resourceUrl) => ({
+            url: new URL(resourceUrl.trim(), suite.url).href,


This resolves each resources.txt entry against suite.url, but tests/unittests/resources.mjs resolves them against the directory of the resources.txt file. For Perf-Dashboard these differ, so all 144 entries resolve to public/v3/public/api/... and 404.

resources: suites/perf.webkit.org/resources.txt

url: suites/perf.webkit.org/public/v3/index.html

I think this goes unnoticed because !response.ok returns 0.

I guess we can use suite.resources to resovle them?

Done — parseSuiteResources now resolves against suite.resources.

canova · 2026-10-20T15:03:17Z

        });
    });

+    describe("isDefault", () => {


This looks like a duplicate of the isDefault describe block above. Probably a merge leftover?

Removed duplicate.

canova · 2026-10-20T15:14:55Z

+    }
+
+    async _unregisterOldServiceWorkers() {
+        const existingRegistrations = await navigator.serviceWorker.getRegistrations();


Hmm, navigator.serviceWorker is undefined in non-secure contexts. And the setup runs even with preload=false, so this throws and the page never reaches the ready state. I think it would be better to not touch the service owrker when the preload is off.

Also getRegistrations() returns every registration on the origin, so this also unregisters the workers of other benchmarks' or Speedometer versions. Could you filter it by scope?

Done — guarded non-secure contexts, skipped SW setup when preload is off, and filtered unregistration by scope.

canova · 2026-10-20T15:15:59Z

+            return;
+        }
+
+        this._validateMessageRouting(data);


_pendingRequest switches to STOP as soon as it's posted, but PROGRESS/DONE messages already in flight from the SW then make this throw inside the listener. The same happens after a timeout. Request ids, with stale replies ignored, would fix it.

Done — added monotonic requestId matching and silently ignore stale SW replies.

canova · 2026-10-20T15:19:48Z

+            const timeSec = (timeTakenMs / 1000).toFixed(2);
+            console.log(`Preloaded ${response.count} files (${sizeMB} MB transferred) in ${timeSec}s`);
+        }
+        this._preloadParams = params.toSearchParams();


I think a preload that's stopped early resolves with null and still sets _preloadParams, so the next isCached() returns true on a partial cache. I think it's better to set it only on PRELOAD_DONE.

Done — _preloadParams is now set only on PRELOAD_DONE and cleared on stop/teardown.

canova · 2026-10-20T15:21:21Z

        if (!this._isStepping())
            this._developerModeContainer?.remove();
+
+        await this._preloadResources(benchmarkConfigurator);


_startBenchmark only guards on isRunning(), and it looks like buttons stay enabled during a post-READY preload. Can we bail on PRELOADING too?

Done — guarded start(), step(), and _startBenchmark() on PRELOADING and disabled start buttons during preload.

canova · 2026-10-20T15:22:04Z

+import { SW_MESSAGES } from "./shared/sw-messages.mjs";
+import { params } from "./shared/params.mjs";
+
+const PRELOAD_TIMEOUT_MS = 60_000;


I don't know if this is a tight window on a slow connection, do you have any idea?

idk, but 1 min seems like a lot to me 🤷

Let's keep 60s for now and see how it scales on slower connections.

Andrew-Fryer · 2026-11-03T16:48:41Z

Also, I think it would be great to write a small explanation at the PR description about the problem this PR is solving.

+1 🙂

IIUC, this should mostly affect the loading process, which is not timed.
Do we have data on how this affects actual scores?

Resolve PR 540 review comments by resolving suite resources relative to suite.resources, correlating service worker messages by requestId, scoping service worker registration cleanup, and guarding non-secure contexts. Synchronize developer mode preload toggles and benchmark UI states while expanding unit and end-to-end test coverage.

Ensure Service Worker registration waits for active controller readiness, synchronize stopPreloading with preloadSuites via _activeStopPromise, and resolve suite.resources against self.location.href. Ensure the home section is visible during preloading, clear stepping state on completion, and add end-to-end coverage for enabling preload from the developer menu.

Replace verbose null and type guards across the Service Worker, preloader, configurator, and parameter parser with optional chaining, and remove redundant DOM element checks in PreloadStatusUpdater.

…l suite

# Conflicts: # tests/index.html

Encapsulate benchmark error state checks behind a dedicated client helper to improve readability and consistency with other lifecycle state predicates.

Use isRunning() and isPreloading() within _setBenchmarkState to align with the rest of MainBenchmarkClient's state predicate patterns.

Encapsulate disabled state check for start buttons into a dedicated helper to match other state predicates on MainBenchmarkClient.

Extract cooperative preemption check into a helper method with documentation on when pending messages may be preempted.

camillobruni · 2026-11-13T17:40:20Z

Fixed the dev-mode preload checkbox; will add a PR description and squash commits before merge.

camillobruni added 5 commits June 10, 2026 16:45

f

45e35c9

add

29a283c

add-resources

d0ba583

more-sw-fixes

f4b8259

pre-format

6a6fe03

camillobruni marked this pull request as draft June 10, 2026 15:42

formatting

a7057a4

camillobruni added 21 commits June 11, 2026 11:40

formatting

1842cf6

f

e35d860

formatting

e77b75f

Merge branch 'main' into 2026-06-10_worker_preload

1e969f3

wip

8b81a14

cleanup

476d9fd

fx

4ed4753

format

f66cd92

add-test

98ae1b8

fix-preload-sync

aea421a

fx

f7e71b6

cleanup

48937dc

revert

f62f7ce

pre-format

7d8010e

pre-format

620b7c8

wrap

b3ea735

pre-format

da2841a

cleanup

201c43b

Fix Chromium Service Worker race condition in e2e tests

90d818f

pre-format

7429e21

camillobruni added 3 commits July 20, 2026 18:46

hard-stop

d71c2c0

throttle-update

93864ff

add-abort-handling

3968599

camillobruni changed the title ~~WIP: service worker preload support~~ Service worker preload support Aug 11, 2026

camillobruni added 2 commits August 18, 2026 11:45

merged

b62c67d

fix-conflicts

6d4185e

camillobruni marked this pull request as ready for review August 18, 2026 09:54

camillobruni added 8 commits August 18, 2026 15:15

Merge branch 'main' into 2026-06-10_worker_preload

07d4816

fix-tests

2b62dd3

fx

0ec2dd2

Merge branch 'main' into 2026-06-10_worker_preload

04cb35d

formatting

a36a80c

fx

56c8d78

fx

97ead47

canova requested changes Oct 20, 2026

View reviewed changes

camillobruni added 12 commits November 13, 2026 11:29

Merge remote-tracking branch 'upstream/main' into pr-540

03e8c2e

Merge remote-tracking branch 'upstream/main' into pr-540

bcddfb7

[preload] Use optional chaining and simplify DOM status updates

b6c3ff8

Replace verbose null and type guards across the Service Worker, preloader, configurator, and parameter parser with optional chaining, and remove redundant DOM element checks in PreloadStatusUpdater.

[preload] Remove unintended TodoMVC-JavaScript-ES5-Cached experimenta…

790cbd6

…l suite

Merge remote-tracking branch 'upstream/main' into pr-540

bfbc4bb

# Conflicts: # tests/index.html

[preload] Add MainBenchmarkClient.isPreloading() helper

c02cdb3

[preload] Add error state helper to MainBenchmarkClient

ac7c9b9

Encapsulate benchmark error state checks behind a dedicated client helper to improve readability and consistency with other lifecycle state predicates.

[preload] Use state helper predicates in _setBenchmarkState

8dfd9b0

Use isRunning() and isPreloading() within _setBenchmarkState to align with the rest of MainBenchmarkClient's state predicate patterns.

[preload] Add isDisabled() helper to MainBenchmarkClient

8349b4f

Encapsulate disabled state check for start buttons into a dedicated helper to match other state predicates on MainBenchmarkClient.

[preload] Add isCooperativePreemption() helper to ResourcePreloader

068673d

Extract cooperative preemption check into a helper method with documentation on when pending messages may be preempted.

Conversation

camillobruni commented Jun 10, 2026

Uh oh!

netlify Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for webkit-speedometer-preview ready!

Uh oh!

netlify Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for webkit-speedometer-preview ready!

Uh oh!

canova left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Andrew-Fryer commented Nov 3, 2026

Uh oh!

camillobruni commented Nov 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Jun 10, 2026 •

edited

Loading

netlify Bot commented Jun 10, 2026 •

edited

Loading

canova left a comment •

edited

Loading