Reorganize workloads into a top-level workloads/ directory - #318
Open
harini9803 wants to merge 1 commit into
Open
harini9803 wants to merge 1 commit into
harini9803 wants to merge 1 commit into
Conversation
Pure cleanup/reorg; no workload changed materially. - Move every workload under workloads/. - Each workload gets its own subdirectory named exactly after its registered name, except closely-related workloads that share files (ARES-6, Octane, RexBench, SeaMonster, SunSpider, bigint, proxy, code-load, babylonjs, prismjs, transformersjs, Dart, dotnet, tfjs-wasm, intl, web-tooling-benchmark). - Drop the wasm/ grouping; Wasm workloads now sit next to the JS ones. Renamed to match workload names: wasm/HashSet -> HashSet-wasm, wasm/TSF -> tsf-wasm, wasm/quicksort -> quicksort-wasm, wasm/gcc-loops -> gcc-loops-wasm, wasm/richards -> richards-wasm, wasm/argon2 -> argon2-wasm, wasm/zlib -> zlib-wasm, wasm/j2cl-box2d -> j2cl-box2d-wasm, wasm/dotnet -> dotnet, sqlite3 -> sqlite3-wasm, 8bitbench -> 8bitbench-wasm, Kotlin-compose -> Kotlin-compose-wasm, mobx -> mobx-startup, TypeScript -> typescript-lib, ARES-6/ml -> ARES-6/ML. Split directories whose workloads shared no files: simple/, generators/, class-fields/, worker/. Updated path references in JetStreamDriver.js, in-depth.html, .prettierignore, .gitignore, tests/run-license.mjs, four webpack.config.mjs files (../utils -> ../../utils), and the root-relative paths hardcoded inside workload sources: transformersjs/benchmark.js (localModelPath, onnx mjs prefix), tfjs-wasm/tfjs.js (WASM_TFJS_DIR), zlib-wasm/shell.js.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #276.
Pure cleanup/reorg — no workload was changed materially.
workloads/.name, except closely-related workloads that share files (ARES-6, Octane,
RexBench, SeaMonster, SunSpider, bigint, proxy, code-load, babylonjs,
prismjs, transformersjs, Dart, dotnet, tfjs-wasm, intl,
web-tooling-benchmark).
wasm/grouping is gone; Wasm workloads sit next to the JS ones.simple/,generators/,class-fields/andworker/were split, sincetheir workloads shared no files.
912 of the 926 changed files are pure renames. Content edits are limited to
five root files (
JetStreamDriver.js,in-depth.html,.prettierignore,.gitignore,tests/run-license.mjs) and nine workload files: fourwebpack.config.mjs(../utils->../../utils), three sources withhardcoded root-relative paths (below), plus a stale comment in
argon2-wasm/benchmark.jsand a stale link indotnet/README.md.Testing
test:chrome -- default— 77 benchmarks, 0 failurestest:chrome -- disabled— 17 benchmarks, 0 failurestest:in-depth— 4/4, incl. the relative-link checktest:license— passes; verified no files silently dropped from checkingprettier— unchanged (same pre-existing warnings asmain)proxy-mobx, groupedSunSpider,and
argon2-wasm— the last one exercises the compressed-resource path thatloads
zlib-wasm/shell.js.Firefox/Safari, and the jsc/spidermonkey shells, are left to CI.
Notes for review
paths hardcoded inside them — invisible to the driver's
files/preloadlists:
transformersjs/benchmark.js(localModelPathand the ONNXmjsprefix),
tfjs-wasm/tfjs.js(WASM_TFJS_DIR), andzlib-wasm/shell.js(shell-only zlib polyfill).
test:buildtriggers on changed directories, and every workload directorymoved, so CI will rebuild all 8 buildable workloads — expect a long run.
wasm/tsf.js/wasm/tsf.wasmare unreferenced leftovers from the initialWebKit import, superseded by
tsf-wasm/build/. I moved rather than deletedthem — happy to drop them in a follow-up if you'd prefer.
RexBench/sunspider_benchmark.jsreferencesSunSpider/...; it's a legacystandalone harness not registered in
BENCHMARKS, and that path was alreadybroken before this change, so I left it alone.