Cassandra Actions - #1729
Open
gonzalotguerrero wants to merge 11 commits into
Open
Conversation
jgaleotti
requested changes
Sep 3, 2026
| * enumerated, it is also what [isSupported] answers from, so that the two cannot disagree. | ||
| */ | ||
| private val GENE_BUILDERS: Map<String, (String) -> Gene> = mapOf( | ||
| "ascii" to { name -> StringGene(name) }, |
Collaborator
There was a problem hiding this comment.
replace these strings with constants
| * column becomes "name type" optionally followed by a " PARTITION KEY" and/or " CLUSTERING" marker, | ||
| * and columns are joined with ", ". | ||
| */ | ||
| object CassandraTableSchemaParser { |
Collaborator
There was a problem hiding this comment.
I am a bit confused. What is the expected grammar for this parser?
| * @return the columns described in [tableSchema], in the same order | ||
| * @throws IllegalArgumentException if any of the described columns is malformed | ||
| */ | ||
| fun parse(tableSchema: String): List<CassandraColumn> { |
Collaborator
There was a problem hiding this comment.
who produces the tableSchema string? What is the expected grammar?
| * Whether the duration is negative, ie the sign shared by the three amounts it is composed of. | ||
| * Explicitly defaulted to false, as [BooleanGene] defaults to true. | ||
| */ | ||
| val negative: BooleanGene = BooleanGene("negative", false) |
Collaborator
There was a problem hiding this comment.
should be isNegative instead of simply negative, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.