Do not emit trailing whitespace on blank lines - #9052
Merged
Conversation
- In printWrap, avoid printing trailing spaces before newlines and on empty lines.
- Remove whitespace indentation before closing parentheses on raw string literal tool descriptions in wasm-opt and wasm-reduce.
- In printStackIR, skip Pop pseudo-instructions before emitting indentation so that they do not produce empty lines with indentation.
The version of filecheck we currently use handles whitespace-only lines fine, but LLVM FileCheck and newer versions of Python filecheck require explicit `{{^ +$}}` regex matchers for such lines. It's nicer to just not emit whitespace-only lines in the first place if we want to upgrade our version of filecheck.
aheejin
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of filecheck we currently use handles whitespace-only lines fine, but LLVM FileCheck and newer versions of Python filecheck require explicit
{{^ +$}}regex matchers for such lines. It's nicer to just not emit whitespace-only lines in the first place if we want to upgrade our version of filecheck.