Repository navigation
Conversation
parseTokenAmount treated a second decimal point as the end of the fraction, so an ERC-20 fund or swap of 1.2.3 was signed as 1.2. An empty amount was signed as zero, and a negative amount came back negative. Native transfers already reject those strings. The token parser now uses the same decimal check as parseAmount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseTokenAmountis what ERC-20 fund and swap amounts go through before they are signed. A second decimal point ended the fraction, so1.2.3was signed as 1.2 USDC (1200000 base units at 6 decimals). An empty string was signed as zero. A negative string came back negative (-1.5at 6 decimals is -500000).Native transfers already reject those strings through
parseEther.parseAmountin the CLI SDK already rejects them with the same decimal check. The token parser now uses that check.Extra fractional digits are still truncated to the token's decimals, which is the behavior
parseAmounttests already lock in.The caller has not been given a checked integer yet. This parser is the check before the transfer is built.
Test plan
npm run build1.2.3,-1.5, and""return a bigint instead of throwing