Skip to content

refactor(review): compose presentation profiles - #234

Closed
Waishnav wants to merge 2 commits into
refactor/v11-runtime-compilerfrom
refactor/v11-presentation-review
Closed

refactor(review): compose presentation profiles#234
Waishnav wants to merge 2 commits into
refactor/v11-runtime-compilerfrom
refactor/v11-presentation-review

Conversation

@Waishnav

@Waishnav Waishnav commented Aug 23, 2026

Copy link
Copy Markdown
Owner

The existing widget mode also controls review checkpoints, show_changes registration, and model guidance, so treating it as presentation-only spreads one workflow across server branches. This layer models off, inline, and change-review presentation profiles and compiles their widget, review lifecycle, tool, and instruction behavior together.

Stacked on #233. The legacy DEVSPACE_WIDGETS values keep their existing behavior.

Stack created with GitHub Stacks CLIGive Feedback 💬

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 82419b50-2ba9-4ff1-9786-b813a9c3fb02

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Waishnav Waishnav changed the title refactor/v11 presentation review refactor(review): compose presentation profiles Aug 23, 2026
@greptile-apps

greptile-apps Bot commented Aug 23, 2026

Copy link
Copy Markdown

Greptile Summary

The PR refactors legacy widget configuration into a compiled presentation contract while preserving the existing off, full, and changes behavior.

  • Maps DEVSPACE_WIDGETS values to explicit presentation modes.
  • Compiles widget metadata, tool registration, workspace initialization, and model instructions into one runtime presentation configuration.
  • Adds integration coverage for each legacy widget mode.

Confidence Score: 5/5

The PR appears safe to merge, with the presentation refactor preserving the existing legacy widget-mode contracts.

Configuration loading, runtime compilation, tool metadata, change-review registration, checkpoint initialization, and instructions remain consistently aligned across all supported modes.

Important Files Changed

Filename Overview
src/presentation.ts Defines the presentation modes and compiles each mode into coordinated widget, tool, workspace, and instruction behavior.
src/config.ts Replaces the internal widget field with PresentationConfig while preserving legacy environment parsing and defaults.
src/runtime-config.ts Adds compiled presentation behavior to RuntimeConfig alongside the existing compiled harness.
src/server.ts Consumes the compiled presentation contract for UI metadata, review initialization, instructions, and show_changes registration without changing legacy behavior.
src/server.test.ts Adds end-to-end assertions that full, changes, and off modes expose the intended tools and UI metadata.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Env[DEVSPACE_WIDGETS] --> Parse[Legacy widget mode]
  Parse --> Map[PresentationConfig]
  Map --> Compile[compilePresentation]
  Compile --> Widgets[Widget metadata]
  Compile --> Groups[Tool registration]
  Compile --> Behaviors[Workspace review initialization]
  Compile --> Instructions[Server instructions]
Loading

Reviews (1): Last reviewed commit: "refactor(review): compose presentation b..." | Re-trigger Greptile

@Waishnav

Copy link
Copy Markdown
Owner Author

Closing this stacked PR because the v1.1 configuration/runtime refactor is being collapsed into one review PR. The commits are preserved in the combined branch.

@Waishnav Waishnav closed this Aug 23, 2026
@Waishnav

Copy link
Copy Markdown
Owner Author

Superseded by the combined v1.1 refactor PR #238.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant