Skip to content

fix(release): disable http.followRedirects on authenticated git commands - #91

Open
wyre-agent-fleet[bot] wants to merge 1 commit into
mainfrom
murph/gh006-followredirects-hardening
Open

wyre-agent-fleet[bot] wants to merge 1 commit into
mainfrom
murph/gh006-followredirects-hardening

Conversation

@wyre-agent-fleet

@wyre-agent-fleet wyre-agent-fleet Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Closes the deferred GH006 hardening item from node-atera#81's CodeRabbit review (task_1788483503324_98138700, item 1): adds -c http.followRedirects=false alongside the existing -c http.extraheader=... on all 3 authenticated git commands in release.yml (fetch --tags, tag push, release/next push).
  • git's http.followRedirects defaults to initial, so the inline Basic-auth header could be sent to a redirected host on the first request of a compromised/malicious redirect — cheap, mechanical fix, no behavior change to normal operation.
  • Same pattern already live on node-halopsa/node-syncro/node-ninjaone (verified before this change) — this brings the remaining 7 of 10 GH006 repos in line.

Test plan

  • Diff is exactly 3 lines changed, one flag added per authenticated git command, no other changes.
  • Verified the pre-change state (flag absent) and the already-fixed repos' exact pattern live via the GitHub API before writing this diff, to match byte-for-byte.
  • Not merging — Aaron-walled per this task family's established convention (see task_1788457898992's original GH006 rollout).

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Closes the deferred GH006 hardening item from node-atera#81's CodeRabbit
review (task_1788483503324_98138700, item 1): git's http.followRedirects
defaults to 'initial', so the inline Basic-auth header (-c
http.extraheader) could be sent to a redirected host on the first
request of a compromised/malicious redirect. Adds -c
http.followRedirects=false alongside the existing -c http.extraheader on
all 3 authenticated git commands (fetch --tags, tag push, release/next
push) in release.yml.

Same pattern already present on node-halopsa, node-syncro, node-ninjaone
(applied separately, verified live before this change). This closes the
remaining 7 of 10 GH006 repos to match.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 557da3f4-114b-4a94-ba72-fe9695bde9f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants