## Fix: Coupon Popup themes not applying their default content (themes 8 / 11 / 12 / 13)

[ShahrearMSf]

On a default (untouched) publish, the new Coupon Popup themes rendered incorrectly — the electronics (theme-twelve) and multi-tier (theme-thirteen) themes shipped with the wrong/empty subtitle, wrong coupon code, and missing coupon tickets, so the front end and the live builder Preview didn't match the design. This affected both Add New and Quick Builder. This PR fixes the theme-default application so every coupon theme renders as designed out of the box.

Reported issues

1. Add New — themes twelve & thirteen don't render per design on the front end when content is left at default.
2. Live Preview — theme-thirteen preview is broken (no subtitle, empty "OFF" ticket).
3. Quick Builder — same default-content mismatch as Add New for theme-thirteen.

Root cause

Three compounding defects:

• Invalid default theme key — Types/Popup.php declared default_theme = 'popup_theme-one', but theme keys are prefixed to popup_notification_theme-one. The initial theme was invalid.
• Conflicting field-level defaults — popup_subtitle and popup_coupon_code carried hardcoded field defaults ("Would like to get the latest news…", "GET35OFF") that pre-filled the fields and blocked each theme's own defaults.
• Framework clobber — popup_subtitle, popup_coupon_code and popup_coupon_repeater are the only fields whose rules exclude the initial theme, so they mount after the builder applies theme defaults and re-initialize to their field default — wiping the theme value. (Fields visible at the default theme, e.g. title/content, were unaffected — which is why only these fields broke.) theme-twelve saved GET35OFF instead of ELEC 4512658; theme-thirteen lost its subtitle and saved a junk repeater row [{index, chosen, selected}] (no tickets).

The fix

• includes/Types/Popup.php — default_theme → popup_notification_theme-one (fully-prefixed key).
• includes/Extensions/PopupNotification/PopupNotification.php
  • Removed the conflicting field-level defaults on popup_subtitle and popup_coupon_code.
  • Added fill_theme_defaults() — fills only empty theme-specific fields from the selected theme's defaults (a repeater row containing only framework metadata counts as empty), so user-typed content is never overridden.
  • Wired it into both save_post (persisted data + front end) and preview_settings (live builder Preview). Both builders share PostType::save_post, so Add New and Quick Builder are covered identically.

Testing / verification

All from fresh, untouched publishes on this branch:

Check	theme-twelve	theme-thirteen
Saved subtitle	64% ✅	And Get Discount Now ✅
Saved coupon	ELEC 4512658 ✅ (was GET35OFF)	tickets #SAVE20 / #SAVE40 ✅ (was junk)
Front-end render	✅ per design	✅ per design
Live builder Preview	✅	✅ (was broken)
Quick Builder save	✅	✅

• theme-two preview also confirmed working; all 11 theme grid previews load correctly.
• No PHP fatals; php -l clean on both changed files.
• Fix touches PHP only — no frontend rebuild required.

cc @priyomukul bhai — please review before merge.