Improve CairoMakie 3D plots - #139
Open
mariekeosw wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
The failed checks might be related to the issue discussed in #137. The failing runs for this PR also use |
pjaap
requested changes
Jul 28, 2026
pjaap
left a comment
pjaap
left a comment
Member
There was a problem hiding this comment.
Nice, thanks for addressing this issue. It should definitely be resolved.
I have some comments below, which should be considered.
| colorbar_ticks = if islog | ||
| ( | ||
| log10.(tickvalues), | ||
| ["10^$(round(Int, log10(t)))" for t in tickvalues], |
Member
There was a problem hiding this comment.
I do not like the hardcoded String ticks here. Is there no legend mechnism in Makie?
If not: Can you use LaTeXStrings, such that 10^x is rendered as LaTeX?
| :viridis, | ||
| "2D/3D contour plot color map (any from [ColorSchemes.jl](https://juliagraphics.github.io/ColorSchemes.jl/stable/basics/#Pre-defined-schemes))" | ||
| ), | ||
| :colorscale => Pair(:linear, "Color scale for scalar plots (:linear or :log; :log requires positive color limits and ticks)"), |
Member
There was a problem hiding this comment.
What about log10 and log2 ? I can image that both may be relevant. If the same mechanism can be re-used, than I suggest to allow for both bases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues I ran into with 3D Makie plots:
Below is an example using electron-density data from my master's thesis.
Linear scale:
Logarithmic scale:
Feedback is very welcome, especially on whether this is the right way to handle the logarithmic scaling!