fix(mobile): keep the panels menu's CDP hook on the shared row - #207
Merged
Conversation
#206 replaced the terminal bar's hand-written menu buttons with DropdownMenuItem and dropped `data-mobile-panel={key}` with them. Nothing in the repo reads that attribute, but nothing reads `data-mobile-terminal-menu` or `data-mobile-session-chip` either — the whole family arrived together in 1817d08 as the selector surface for driving the Android build over CDP, and this is the one member that went missing. DropdownMenuItem takes a `dataAttrs` map so a shared row can carry the hook the hand-written button carried. It matters more here than elsewhere: the mobile shell only mounts when the backend reports `android`, so this menu cannot be reached from the desktop build and those selectors are how it gets exercised at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#206 replaced the terminal bar's hand-written menu buttons with
DropdownMenuItemand dropped
data-mobile-panel={key}along with them.Nothing in the repo reads that attribute — but nothing reads
data-mobile-terminal-menu,data-mobile-session-chipordata-mobile-panel-quickeither. The whole family arrived together in
1817d08aas the selector surface fordriving the Android build over CDP, and this is the one member that went missing.
DropdownMenuItemnow takes adataAttrsmap, so a shared row can carry the hookits hand-written predecessor carried.
It matters more here than it would elsewhere: the mobile shell only mounts when the
backend reports
android, so this menu cannot be reached from the desktop headlessbuild — those selectors are how it gets exercised at all, and there is no emulator
available to fall back on.
Found by re-reading the #206 diff for what it silently removed, rather than for what
it changed.
tsc --noEmitclean; 190 tests acrossmobile,sharedandterminalpass.