Skip to content

fix(auth): stop logging account_id on registration #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kipavy merged 1 commit into from
Sep 1, 2026
Merged

fix(auth): stop logging account_id on registration #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/routes/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,14 @@ pub async fn register(
StatusCode::INTERNAL_SERVER_ERROR
})?;

// `account_id` is deliberately absent: despite the name it is the KDF salt
// passed to derive_keys, so a log line carrying it hands anyone who can read
// the logs an offline precompute against that user's password. `user_id`
// identifies the registration, and the two are joinable in the database.
if trial_blocked {
info!(user_id = %user_id, account_id = %body.account_id, "User registered on free tier (trial already used)");
info!(user_id = %user_id, "User registered on free tier (trial already used)");
} else {
info!(user_id = %user_id, account_id = %body.account_id, "User registered with 14-day trial");
info!(user_id = %user_id, "User registered with 14-day trial");
}

Ok((
Expand Down