fix(queue): delete orphaned jobs before initializeScheduling() so next_schedule actually resets#49
Merged
Conversation
…ialization Reordered the logic in both `Queue/FixCommand.php` and `QueueCommand.php` to delete orphaned jobs before initializing scheduling. This ensures that the scheduler correctly resets `next_schedule` for run-templates when orphans are present, addressing issue #48. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesQueue cleanup ordering
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queue:fix(both the newQueue/FixCommand.phpand the legacyQueueCommand.phpfixaction) calledScheduler::initializeScheduling()before deleting orphaned job rows. SinceinitializeScheduling()only resets a run-template'snext_schedulewhen it finds no matching job row, it always saw the soon-to-be-deleted orphan and skipped the reset — leavingnext_schedulepermanently stuck at a dead slot with no way to naturally re-trigger.initializeScheduling()runs against the now-accurate state.Test plan
php -lon both changed filesphpunitrun — this repo has nophpunit.xml, so the suite isn't runnable standalone in the environment I used; the existingQueueCommandTestalso requires a live MySQL instance matching.env, which wasn't available. The change is a pure statement reorder with no logic changes, verified by reading — please run CI/local suite before merge.🤖 Generated with Claude Code
Summary by CodeRabbit