Refactoring the code of phase 2 - #12
Merged
Merged
Conversation
… to separate them into 2 different packages. This makes the code easier to read and removes the confusing interface that we had in the sstable that was used for compaction
…for the database struct
…o tests should work now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I basically refactored the way we handle reads and write from the memtable and the SSTable files by creating structs that represent a SSTable file and a Database that would handle all reads and writes done in the database. This was made with the sole focus of improved readability, and making it easier to transition into bloom filters.