Skip to content

Mannequin name improvements for 1.21.9->1.21.7 - #1312

Open
roccodev wants to merge 1 commit into
ViaVersion:masterfrom
roccodev:feature/mannequin-improvements
Open

Mannequin name improvements for 1.21.9->1.21.7#1312
roccodev wants to merge 1 commit into
ViaVersion:masterfrom
roccodev:feature/mannequin-improvements

Conversation

@roccodev

@roccodev roccodev commented Aug 31, 2026

Copy link
Copy Markdown

This slightly changes the way mannequin names are handled:

  • When spawning the second entity, the new name from the profile is now used to name the player info entry. This is nice because it allows registering the mannequin in scoreboard teams.
  • Team registration is only performed when the second entity is spawned, this is because the mannequin's name can change in-between due to the above. Perhaps I could also add a way to disable this, because in some cases (I'd imagine on track/untrack) it may override the team set by the server/plugins?
  • When the mannequin has no CustomName, its nametag is hidden (by setting the option in its team), which matches 1.21.9+ behavior. Technically in 1.21.9 this depends on CustomNameVisible (otherwise the name can display but only on hover), not sure whether I should change it to match that, because in 1.8 and 1.9 the name is either always displayed or always hidden.

I also wanted to remove them from tablist after spawning (for versions that don't have the Listed flag, primarily 1.8) to match the vanilla behavior. Unfortunately, this has to be handled by server implementations because the vanilla 1.8 client needs to render the player at least once to save its skin (amazing implementation), which means the player info remove packet has to be delayed slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant