Repository navigation
chore(deps): bump very_good_analysis from 10.3.0 to 11.0.0 - #137
Conversation
Bumps [very_good_analysis](https://github.com/VeryGoodOpenSource/very_good_analysis) from 10.3.0 to 11.0.0. - [Release notes](https://github.com/VeryGoodOpenSource/very_good_analysis/releases) - [Changelog](https://github.com/VeryGoodOpenSource/very_good_analysis/blob/main/CHANGELOG.md) - [Commits](VeryGoodOpenSource/very_good_analysis@v10.3.0...v11.0.0) --- updated-dependencies: - dependency-name: very_good_analysis dependency-version: 11.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dart
dependabot
Bot
added
dart
erickzanardo
left a comment
erickzanardo
left a comment
There was a problem hiding this comment.
This Dependabot PR changes one line in pubspec.yaml: the very_good_analysis dev dependency goes from ^10.3.0 to ">=10.3.0 <12.0.0". Because Dependabot widened the range instead of bumping it, the PR doesn't actually require 11.0.0. 11.0.0 adds seven new lint rules (including use_declaring_parameters, unnecessary_type_name_in_constructor, initialize_in_field_declaration, unnecessary_const_in_enum_constructor and async_return_with_no_await) and turns on automatic trailing commas.
I couldn't run dart analyze (shell access was denied here), so I don't know whether the new rules produce violations. The codebase does have patterns they are likely to flag, such as const SystemShell(this.name); final String name; in lib/src/system_shell.dart and the many this.field constructors in lib/src/parser/. If CI resolves to 11.0.0 and analysis fails on these, fixes are needed before merging.
example/pubspec.yaml is left at ^10.3.0 and isn't part of this PR. Previous bumps used separate PRs for the root and /example.
Overall: it's low risk, but I'd change the constraint to ^11.0.0, confirm the CI analyze step passes with 11.0.0 (fixing any new lint violations in this PR), and bump the example too.
github-project-automation
Bot
moved this from Needs Triage
to In Review
in VGV Open Source 馃 馃馃専
|
/unicoder fix the CI and address the comments on the review |
|
I stopped before starting: the SDK this repository is configured with cannot build it.
Update the flutter version in this repository's bot settings, or set it to |
|
/unicoder I've fixed the versions, address the comments and fix CI now please |
|
I've pushed changes to address the feedback. |
Co-authored-by: erickzanardo <erickzanardo@users.noreply.github.com>
1 participant
Bumps very_good_analysis from 10.3.0 to 11.0.0.
Release notes
Sourced from very_good_analysis's releases.
Changelog
Sourced from very_good_analysis's changelog.
Commits
1e84c31chore: 11.0.0 (#240)a37cef7chore: bump version to 11.0.0 (#239)0fb6ff3chore(deps): bump dart-lang/setup-dart from 1.8.0 to 1.8.1 (#238)b4fce77chore: 11.0.0-rc.1 (#229)60d33b5feat: addunnecessary_type_name_in_constructorrule (#232)8c90ca8feat: addasync_return_with_no_awaitrule (#231)da69fb6feat: addinitialize_in_field_declarationrule (#230)a301996feat: adduse_declaring_parametersrule (#233)53e3f8bfeat: addunnecessary_primary_constructor_bodyrule (#234)2cf53e8feat: addunnecessary_const_in_enum_constructorrule (#235)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)