Fix password hash disclosure in artifacts/db-reset.js - #124
Open
legit-app-ci[bot] wants to merge 1 commit into
Open
Fix password hash disclosure in artifacts/db-reset.js#124legit-app-ci[bot] wants to merge 1 commit into
legit-app-ci[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This PR remediates a Password hashes should not be disclosed finding in
artifacts/db-reset.js(lines 7–67).The database reset script was storing plaintext passwords (
"Admin_123","User1_123","User2_123") and commented-out bcrypt hashes directly in theUSERS_TO_INSERTarray. This exposed credentials in version control and would have inserted plaintext passwords into the MongoDB users collection.Changes
const bcrypt = require("bcryptjs");to enable runtime password hashingpasswordfields from the three user objects inUSERS_TO_INSERThashPasswordhelper function that generates bcrypt hashes with 10 salt roundsMongoClient.connectcallback to be asyncEach user now receives a freshly-generated bcrypt hash when the script runs, ensuring no credentials are committed to source control.