Repository navigation
Conversation
Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid compressed A2S responses are rejected whenever their CRC32 has its high bit set. The wire checksum is unpacked as a signed integer, while Python 3 returns an unsigned CRC32. A valid rules response therefore raises a checksum mismatch instead of returning the server rules.
Read the checksum as an unsigned 32-bit value and normalize the computed CRC32 to the same bit pattern. This also accommodates the signed crc32 result returned by Python 2. Keep the existing decompressed-size and corruption checks.
Validation:
No live Steam server was contacted. Other compressed packet-layout variants and the remaining interpreter/platform matrix are outside this focused checksum fix.
AI assistance: implementation and regression tests were prepared with OpenAI Codex and have passed an independent code and regression-test review before submission.