Skip to content

fix(pm): couple closed-market retention to the commit reveal deadline (validate bound) #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
On1x merged 1 commit into from
Aug 13, 2026
Merged

fix(pm): couple closed-market retention to the commit reveal deadline (validate bound) #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions libraries/protocol/include/graphene/protocol/chain_operations.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,18 @@ namespace graphene { namespace protocol {
FC_ASSERT(pm_commit_no_reveal_penalty_percent <= 10000, "pm_commit_no_reveal_penalty_percent out of range");
FC_ASSERT(pm_batch_epoch_blocks > 0, "pm_batch_epoch_blocks must be positive");
FC_ASSERT(pm_reveal_window_blocks > 0, "pm_reveal_window_blocks must be positive");
// A commit's reveal deadline can fall up to (batch_epoch + reveal_window) blocks
// after the commit (pm_commit_bet), and its escrow is only refunded/forfeited by the
// reveal-forfeit cron at that deadline. gc_market deletes commit rows unconditionally
// once a market has been finalized for pm_closed_market_retention_sec. Require the
// retention to strictly exceed the worst-case reveal deadline so a still-unrevealed
// commit can never be garbage-collected before its escrow is returned — makes the
// "commit is always cleared before GC" invariant hold by construction, not by the
// default parameter magnitudes (5 d vs ~11 min) alone.
FC_ASSERT(pm_closed_market_retention_sec
> (uint64_t)(pm_batch_epoch_blocks + pm_reveal_window_blocks) * CHAIN_BLOCK_INTERVAL,
"pm_closed_market_retention_sec must exceed the worst-case commit reveal deadline "
"((pm_batch_epoch_blocks + pm_reveal_window_blocks) * CHAIN_BLOCK_INTERVAL)");
FC_ASSERT(pm_processing_cap_per_block > 0, "pm_processing_cap_per_block must be positive");
FC_ASSERT(pm_lazy_alloc_percent <= 10000, "pm_lazy_alloc_percent out of range");
FC_ASSERT(pm_lazy_max_total_alloc_percent <= 10000, "pm_lazy_max_total_alloc_percent out of range");
Expand Down