Repository navigation
Add 'boundary' parameter for constrained triangulation of neighbours … - #38
Merged
Merged
Conversation
…rbanAnalyst#5) scl_redcap() and scl_full() gain an optional 'boundary'. When given, spatial neighbours come from a constrained Delaunay triangulation of the points and boundary rings (via 'cdtr', in Suggests), with triangles outside the boundary or inside holes removed, so no neighbour edges cross outside the study region. If boundary vertices leave the point graph disconnected, MST edges are added as in scl_edges_nn().
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 90.96% 91.21% +0.25%
==========================================
Files 19 19
Lines 1771 1879 +108
==========================================
+ Hits 1611 1714 +103
- Misses 160 165 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Awesome work, thanks so much Mike! Can you add yourself as "aut" to DESC too please? I'd also like a clear example, but I'll do that myself, which'll be a great way for me to understand exactly what your code adds here. |
Contributor
Author
|
awesome, can follow up with examples if you want more (not sure when tho .. gettin hectic here) |
Member
|
Thanks - I'll elevate you from "ctb" to "aut", coz those are definitely entire new functions you've authored there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#5)
scl_redcap() and scl_full() gain an optional 'boundary'. When given, spatial neighbours come from a constrained Delaunay triangulation of the points and boundary rings (via 'cdtr', in Suggests), with triangles outside the boundary or inside holes removed, so no neighbour edges cross outside the study region. If boundary vertices leave the point graph disconnected, MST edges are added as in scl_edges_nn().