vps-115-context-menus-noticeably-flicker-at-previous-position - #451
vps-115-context-menus-noticeably-flicker-at-previous-position#451K1mmyn wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesContext menu event handling
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
harbassan
left a comment
There was a problem hiding this comment.
Virtual.Patient.System.-.UoA.Mozilla.Firefox.2026-07-27.23-38-02.mp4
There was a problem hiding this comment.
Screencast_20260727_235200.webm
it is working for me idk hartej, im on firefox browser
the other sort of flicker thats happening seems to be from the previous context menu location so could not be closing properly or smthn like that
|
yeah i think that tiny flicker you have at the start of your video is the one im having all the time, where there is a render that happens at the previous location before a rerender at the new location. |
Issue
The main cause for the flicker is that, the current function which create the context menu check onmouseup if your cursor is on a piece of html which is apart of the context menu. This bug happens when you are holding right click and move your cursor off the context menu and release right click.
Solution
Change from mouseup to mousedown because it is guaranteed that the mouse will start on top of the context menu due to negative offset
Risk
NONE
Checklist
Summary by CodeRabbit