Repository navigation
fix: reject blank repository names and sources - #23
Merged
Merged
Conversation
Validate required repository text before create or update writes, so an empty or whitespace-only edit cannot erase a usable source. Keep invalid edits open with required-field guidance and preserve the unsaved draft. Retain exact nonblank source strings and omitted-field behavior. Add API atomicity and real dashboard form regressions covering rejection, correction, and ordinary source formats. Validation: 31 focused regressions and 129 adjacent tests passed in independent review; lint, formatting, type checks, and removed-guard counterexamples passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An existing repository could be saved with an empty name or source, leaving later tasks unable to launch. Reject blank or whitespace-only required fields before writing, and keep the edit form open with an inline error and its draft intact.
Valid source strings and omitted fields retain their existing behavior. This adds 12 production lines plus focused API and dashboard regressions for rejection, atomicity, correction, and normal source formats.
Validation: 31 new regression cases and 129 adjacent tests passed in independent review; lint, formatting, and strict type checks passed. An installed-wheel check also confirmed blank-field rejection without mutation and successful correction through the real terminal UI. Both independent reviews approve the exact commit. All CI checks pass, including lint, formatting, type checks, the full test suite, wheel build/installation, and macOS/Linux startup smoke tests.