Fix file_mode and dir_mode descriptions - #800
davidnewhall wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Documentation and dependency pinning still need correction and alignment.
Review effort: Lite
Findings: 3
Open (3)
What changed in this PR
Updates file_mode and dir_mode descriptions to reflect xtractr behavior and bumps the xtractr dependency.
Changes:
- Updates configuration, example, and localized mode documentation.
- Refreshes xtractr dependency metadata.
- Simplifies integration-test package commands.
| File | Summary |
|---|---|
pkg/configdef/definitions.yml |
Updates mode descriptions and recommendations. |
go.sum |
Refreshes dependency checksums. |
go.mod |
Pins a newer xtractr revision. |
frontend/src/lib/i18n/locales/nl.json |
Updates Dutch mode tooltips. |
frontend/src/lib/i18n/locales/es.json |
Updates Spanish mode tooltips. |
frontend/src/lib/i18n/locales/en.json |
Updates English mode tooltips. |
frontend/src/lib/i18n/locales/el.json |
Updates Greek mode tooltips. |
examples/unpackerr.conf.example |
Updates generated mode guidance. |
.github/workflows/inttest.yml |
Adjusts integration-test package commands. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Reviewed 7fa80e8 against e1ef315 (main). Three changes are bundled here: the new file_mode/dir_mode wording (definitions.yml, regenerated example config, all four locales), the xtractr bump to 5b2947ec implementing that behavior (golift/xtractr#215; also drags in the upstream MaxRatio numerator change and two dependency bumps), and an apt-get → apt cleanup in inttest.yml.
I verified the new wording against actual extraction behavior with both the old and new xtractr:
- Stored file mode 0644 + file_mode 0660 → 0664 (group write added); stored 0755 + 0660 → 0775.
- Entries storing no mode get the full configured mode (0660, 0770).
- Stored directory 0555 → 0775: owner rwx restored, group bits added, as written.
- Umask applies at open as documented: 0666 → 0644 under umask 0022, for both stored and unmodeled entries.
So the descriptions match what the bumped library does. The el/es/nl translations carry every clause of the English text, go generate reproduces the committed example file exactly apart from the timestamp footer, and the v1.0.0 September → October correction matches INTERNALS.md.
One wording nit on the file_mode description below; everything else is accurate. Approving.
Executed validation:
go test ./...at head: all packages pass.go generate ./...at head: regenerated example config and compose are identical to the committed ones except the generated timestamp.npm run check(svelte-check) at head: 0 errors, 0 warnings.- xtractr test suite at the pinned
5b2947ec: passes, including the newTestSafeFileModeAddsNonOwnerBits/TestSafeDirModeAddsNonOwnerBits. - Disposable extraction harness: a tar containing modes 0755/0555/0644/0755/0000 and a zip, extracted with umask 0 and umask 0022 against xtractr
3616e46c(old) and5b2947ec(new), confirming the old full-preserve semantics changed exactly as described.

Update the descriptions for
file_modeanddir_modeinputs. Bump xtractr lib to main.