fix: prevent aiohttp from becoming mandatory to use the sync SDK - #441
Conversation
to do so, I've moved the async metrics reporter to its own file.
daveleek
left a comment
There was a problem hiding this comment.
OK good stuff!
Is there a reason the tests couldn't stay in the same file? The moving of the test code contributed to the most of this PRs lines of change, and made it a little more difficult to figure out which parts were critical to review and not. I think if would've been possible (maybe for a similar next time) I would've appreciated them being split in a separate PR
Ooff, totally. I just wanted to do it in one fell swoop. But it's true that the tests part made it hard. Noted for the next one! |
While testing the SDK I've found that to do
from UnleashClient import UnleashClientnow you have to have aiohttp installed. By splitting this files, now it can remain an optional dependency, like it was intended from the beginning.Stack created with GitHub Stacks CLI • Give Feedback 💬