EG-4749: Implementation of the AsyncUnleashClient - #439
Merged
Merged
Conversation
sighphyre
reviewed
Sep 28, 2026
|
|
||
| if not self._config.disable_metrics: | ||
| self._metrics.start() | ||
| self._scheduler.start() |
Member
There was a problem hiding this comment.
This badboy is literally only for the metrics right? Can we call it that? I spent a few minutes trying to figure out why we didn't want features to be resolved if metrics was off - partially because I'm dumb but also partially because if you've worked with SDKs before you expect a scheduler to be closely related to feature poll cycle.
Not a biggie either way
sighphyre
approved these changes
Sep 28, 2026
sighphyre
left a comment
sighphyre
left a comment
Member
There was a problem hiding this comment.
Amazing, feels like hitting a finish line!
ppicom
force-pushed
the
eg-4749-init-client
branch
from
September 28, 2026 13:21
8026175 to
b8ca33b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heads up! 🎉 This class is the culmination of the refactor. It puts together all the classes we've introduced during the refactor into our brand new Async client.
Two things to take into account:
is_enabledandget_variantare not corroutines and it's on purpose. Our value proposition is that your flags evaluate fast, so no async there.fetch_togglesis not supported (yet?) in this client. Coming soon in a follow-up pull request.BootrstapConnectorinto this bad boy felt like a bad design decision. Is it really a connector if it does something different from a connector? Bootstrapping doesn't feel like something that should havestart()andstop(). Therefore, I've delayed this decision to a follow-up PRWell, those were three things... awkward!
Stack created with GitHub Stacks CLI • Give Feedback 💬