EG-4747: Make metrics reporters private and move them to the same module - #434
Merged
Merged
Conversation
ppicom
force-pushed
the
eg-4747-private-metrics
branch
from
September 28, 2026 13:21
5348a62 to
e39259e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes more collaborators private. Again, the
MetricsReporterandAsyncMetricsReporterwere introduced as part of the refactor to add support for an async client. Our users should not depend on it directly.hence, following python conventions I am marking them as private.
Also, I've taken the opportunity to "shrink" the surface of our SDK by moving both sync and async recorders to the same
_metrics.pymodule. Having two files madeimportstatements a bit akward (IMO).Stack created with GitHub Stacks CLI • Give Feedback 💬