EG-4747: Make FeatureStore a private collaborator - #433
Merged
Merged
Conversation
This is one of those abstractions that we still don't know if we will keep, hence making it private to stay out of trouble.
ppicom
force-pushed
the
eg-4747-private-featurestore
branch
from
September 28, 2026 13:21
1437f02 to
eb4cedf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to what we did in previous commits for _Transport and _AsyncTransport, the
FeatureStoreis also a new abstraction that we are adding.Following Python convention, I'm prefixing it with an underscore ("_") to clearly signal that it's not part of the public API of the SDK.
Stack created with GitHub Stacks CLI • Give Feedback 💬