EG-4747: make AlreadyClosedError part of the hierarchy of SDK errors - #432
Merged
Merged
Conversation
ppicom
added this pull request to stack #440
September 28, 2026 10:53
ppicom
force-pushed
the
eg-4747-hierarchical-error
branch
from
September 28, 2026 13:21
36c6162 to
9a1da92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back when coding the Transport and AsyncTransport, we introduced a new error type that our users can depend on and code around:
AlreadyClosedError.Errors are part of the SDK's API. Hence, in this PR I am making that new error part of the "error hierarchy" that I introduced a few pull requests back.
This change gives more support to fine grained Exception control from our users: you can capture UnleashClientError and grab all errors from our SDK, you can catch Error (e.g.
TransportError) and deal with a whole set of related errors, or just catch one specific error.Stack created with GitHub Stacks CLI • Give Feedback 💬