Bump jest and @types/jest - #1838
Conversation
Bumps [jest](https://github.com/jestjs/jest/tree/HEAD/packages/jest) and [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest). These dependencies needed to be updated together. Updates `jest` from 29.7.0 to 30.4.2 - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v30.4.2/packages/jest) Updates `@types/jest` from 29.5.13 to 30.0.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: jest dependency-version: 30.4.2 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: "@types/jest" dependency-version: 30.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
demiankatz
left a comment
There was a problem hiding this comment.
This is breaking the build; probably means there's a backward compatibility break in the new major version that needs to be accounted for in some of our tests.
|
@demiankatz, I had a look into this and was able to reproduce the issue consistently on this PR. On I checked the dependencies and it looks like the issue is coming from the current So it looks like we're ending up with a mix of Jest 30 and Jest 29 packages in the test environment, which seems to be why the test are failing during setup. |
|
Thanks, @LanieOkorodudu -- I took a look at the https://github.com/argos-ci/jest-puppeteer repository, and it doesn't look particularly healthy. As you say, no new release in two years, and not much activity of any sort. It might be worth doing some research to see if there's a better way to integrate jest and puppeteer; maybe this particular npm package is no longer the best practice. I'm happy to help with that research if you need me to, though I still have to catch up on a few other things before I'll have much bandwidth. Please let me know if I should put anything on my to-do list, and in any case, thanks for helping to move this forward! Glad that we have a better understanding of the problem now. |
Thanks for taking the time to look into this. I'll do some more digging and research on my side to see if there's a better way to integrate Jest and Puppeteer. I'll reach out if I find a possible solution or need some help along the way. Thanks again! |
|
We could try removing jest-puppeteer and using a custom test environment instead - there's an example here: |
@demiankatz, should we try this approach. |
It seems worth a try -- it's a shame to have to do everything manually, but it doesn't look too complicated, and if it eliminates an abandoned dependency, it's probably worth doing. Let me know if you need any help with the details! |
Bumps jest and @types/jest. These dependencies needed to be updated together.
Updates
jestfrom 29.7.0 to 30.4.2Release notes
Sourced from jest's releases.
... (truncated)
Changelog
Sourced from jest's changelog.
... (truncated)
Commits
746f2a0v30.4.2b3b4a09v30.4.15cbb21ev30.4.0db7141afix: allowcollectCoverageandcoverageProviderin project config (#16132)efb59c2v30.3.096c53d3feat(jest-config): adddefineConfigandmergeConfigfunctions (#15844)855864ev30.2.0da9b532v30.1.3ebfa31cv30.1.2d347c0fv30.1.1Updates
@types/jestfrom 29.5.13 to 30.0.0Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)