Repository navigation
fix: preserve source lines for repeated configuration keys - #213
Open
BasilZafar11 wants to merge 3 commits into
Open
BasilZafar11 wants to merge 3 commits into
BasilZafar11 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated configuration keys were all attributed to their first source occurrence. Two identical hook commands on lines 4 and 5 consequently reported lines 4 and 4, letting a line-specific ignore suppress both. They now report their own lines, and either occurrence can be suppressed independently.
Closes #165.
Changes
first_seen_linevalues are corrected. Baseline identity already excludes line numbers, so the fingerprint algorithm and count budget remain unchanged.yaml-rust20.10.4 adds source marks with encoding features disabled (four transitive packages).toml_edit0.22 was already a locked dependency and is now used directly for spans. ADR-007 records the decision and fallback limits. README explains the corrected suppression behavior. No detection patterns, severities, report schemas, or recall expectations changed.Validation
cargo test --locked --no-fail-fast -- --skip findings_name_the_repository_path_not_the_staging_copy: 493 passed, 0 failed, 1 filtered out in the final full run. The existing Windows-only assertion is excluded because it expectsdocs/CLAUDE.mdwhile Windows reports.\docs\CLAUDE.md; its test and implementation are unchanged. An earlier catalogue check encountered Windows checkout line endings; regenerating the catalogue fixed it with no Git content diff.--all-targets --locked -- -D warnings, formatting, and diff checks pass.Branch created from freshly fetched upstream main
e1bf8b6; fork main matches that commit. No production unwraps or debug output added. Existing clean specimens and sealed held-out payloads are unchanged.