Repository navigation
test: measure PI079 key-blob threshold against independent specimens - #200
Merged
hermanngeorge15 merged 4 commits intoOct 23, 2026
Merged
Conversation
hermanngeorge15
approved these changes
Oct 23, 2026
hermanngeorge15
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: no detection change (regex and MEDIUM grade untouched); the {40,}-after-AAAA arithmetic and the corrected Ed25519 comment check out; payload text stays in tests/fixtures; the evidence tests guard their own assumptions (one {40,} occurrence, three specimens). After updating onto main with #197, the catalogue matches a fresh regeneration and the whole-repo baselined scan is 0 findings. Thanks — this turns #180's open question into a measurement.
hermanngeorge15
added a commit
that referenced
this pull request
Oct 23, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hermanngeorge15
added a commit
that referenced
this pull request
Oct 23, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PI079 had no independent literal-key specimens behind its length cutoff or severity. This adds sourced command excerpts and runnable threshold measurements, and changes the finding's remediation to check explicit user authorization instead of unconditionally removing a legitimate SSH installation command.
Closes #180.
Evidence and decision
AAAAcharacters plus the{40,}quantifier means 44 total base64 characters, excluding padding. Synthetic boundary tests are explicitly separate from independent evidence.Full provenance, measured outcomes, and limitations are in
docs/PI079-EVIDENCE.md. The new excerpts live outside the zero-finding clean corpus because authorized and unauthorized key installation can have identical syntax. Existing clean specimens and recall pins are unchanged.Validation
cargo test --locked --test pi079_evidence_test: all 3 tests pass.cargo clippy --all-targets --locked -- -D warningsandcargo fmt --all -- --check: pass.cargo test --locked --no-fail-fast -- --skip findings_name_the_repository_path_not_the_staging_copy: 468 passed, 0 failed, 1 filtered out. The excluded pre-existing Windows-only path assertion expectsdocs/CLAUDE.mdbut receives.\docs\CLAUDE.md; neither that test nor its implementation is changed. The final evidence tests were rerun after adding a fixture-count guard, and all 3 pass.Started directly from freshly fetched upstream main
edec71c; the fork's main matched that commit. No engine/schema/output-contract changes or dependencies, so no ADR is required. No production unwraps, debug output, or catch-all pattern matches added.