You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds support for using the VASPsol++ extension to VASP with version 6.3.2. Support is enabled for VASPsol++ both with and without VTSTtools. Patch files were supplied directly by Craig Plaisance, the author of VASPsol++. Slight modifications were made to the original patch files for compatibility with the Spack install process.
Thank you for providing these patches and for clarifying their provenance. Could you please confirm whether vaspsol++-vasp_6.3.2.patch and vaspsol++-vtst-vasp_6.3.2.patch are the original upstream patch files supplied by Craig Plaisance, or Spack-specific modified versions derived from those original files?
Since the description mentions that slight modifications were made for compatibility with the Spack installation process, could you also indicate exactly what was changed? If possible, could you provide the original patch files, their checksums, or a diff against the original versions? This would help users distinguish the official upstream VASPsol++ 6.3.2 patches from the Spack-adapted versions when performing a manual installation.
It would also be helpful to confirm whether the VTST patch specifically targets vtstcode-209. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using the VASPsol++ extension to VASP with version 6.3.2. Support is enabled for VASPsol++ both with and without VTSTtools. Patch files were supplied directly by Craig Plaisance, the author of VASPsol++. Slight modifications were made to the original patch files for compatibility with the Spack install process.