feat: expose BufferedLinearInterpolator's less smoothed Update - #4143
Open
ToxPlayers wants to merge 1 commit into
Open
Conversation
Member
|
We have some pending changes for the BufferedLinearInterpolator in #4130. Will those changes help here? Or is this separate to what you're wanting? |
Author
Member
We will look at exposing this method soon for v2.x.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Exposed the more precise version of BufferedLinearInterpolator. The other update method is exposed but is more smoothed as explained in its existing doc. I've been using this more precise version and manually exposing it when the package is updated. I don't see a reason for it to be internal only.
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
I've been using the function for my projects for a while and also tested it in this branch with no issues.
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
Needed, should be exposed in 3.0.0 too
Backports
Not needed