Skip to content

ci: Fix code coverage command in YAML configuration#4069

Merged
NoelStephensUnity merged 2 commits into
develop-2.0.0from
ci/fix/coverage-reporting
Jul 8, 2026
Merged

ci: Fix code coverage command in YAML configuration#4069
NoelStephensUnity merged 2 commits into
develop-2.0.0from
ci/fix/coverage-reporting

Conversation

@unity-nikos

@unity-nikos unity-nikos commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Purpose of this PR

[CI] Fix code coverage command in YAML configuration

Coverage reporting was not setup due to this

Initiative was triggered from this Discussions thread

Jira ticket

n/a

Changelog

  • Fixed: [CI] Fixed code coverage command in YAML configuration

Documentation

Notes to reviewers

Testing & QA

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

Needs to be ported to develop branch potentially

Coverage reporting was not setup due to this
@unity-nikos unity-nikos requested review from a team, EmandM and NoelStephensUnity as code owners July 8, 2026 14:05
@cla-assistant-unity

cla-assistant-unity Bot commented Jul 8, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@michalChrobot michalChrobot changed the title [CI] Fix code coverage command in YAML configuration ci: Fix code coverage command in YAML configuration Jul 8, 2026
@michalChrobot

michalChrobot commented Jul 8, 2026

Copy link
Copy Markdown
Member

Thanks for catching this typo, I remember at some point I wanted to investigate why NGO doesn't show in CodeCov but I never got to it.

I wouldn't bother backporting to develop as we don't really backport anything there (develop branch corresponds to NGOv1.X version while develop-2.0.0 corresponds to lates NGOv2.X version on which we continue our development)

Code Coverage - NGO [ubuntu, 6000.3] should run on PR trigger

I think I would simply add it to daily trigger to not increase PR waiting time (as code coverage results wouldn't block the PR anyway and those tests are run itself by other jobs).

@unity-nikos

Copy link
Copy Markdown
Contributor Author

com.unity.netcode.gameobjects in Codecov

@unity-nikos

unity-nikos commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

I think I would simply add it to daily trigger to not increase PR waiting time (as code coverage results wouldn't block the PR anyway and those tests are run itself by other jobs).

Please also add it as dependency to the PR Trigger job i.e. Minimal PR checks in pr_minimal_required_checks

In case you'd like to make use of the PR comment

Execution time of the coverage job is ~30min

Codecov check is informational: true, and it doesn't block PRs

@NoelStephensUnity NoelStephensUnity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Thank you for fixing this!
:godmode:

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) July 8, 2026 22:48
@NoelStephensUnity NoelStephensUnity merged commit f4dfd4e into develop-2.0.0 Jul 8, 2026
17 of 18 checks passed
@NoelStephensUnity NoelStephensUnity deleted the ci/fix/coverage-reporting branch July 8, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants