ci: Fix code coverage command in YAML configuration#4069
Conversation
Coverage reporting was not setup due to this
|
Thanks for catching this typo, I remember at some point I wanted to investigate why NGO doesn't show in CodeCov but I never got to it. I wouldn't bother backporting to
I think I would simply add it to daily trigger to not increase PR waiting time (as code coverage results wouldn't block the PR anyway and those tests are run itself by other jobs). |
|
com.unity.netcode.gameobjects in Codecov |
Please also add it as dependency to the PR Trigger job i.e. Minimal PR checks in pr_minimal_required_checks In case you'd like to make use of the PR comment Execution time of the coverage job is ~30min Codecov check is informational: true, and it doesn't block PRs |
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Awesome!
Thank you for fixing this!
![]()
Purpose of this PR
[CI] Fix code coverage command in YAML configuration
Coverage reporting was not setup due to this
Initiative was triggered from this Discussions thread
Jira ticket
n/a
Changelog
Documentation
Notes to reviewers
developbranch, I guessTesting & QA
Code Coverage - NGO [ubuntu, 6000.3]
com.unity.netcode.gameobjects in Codecov
Automated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
Needs to be ported to
developbranch potentially