CMCL-0000: Add message banner for Cinemachine 3 - #1124
Open
fatimah-mf-unity wants to merge 2 commits into
Open
Conversation
|
|
fatimah-mf-unity
changed the title
fatimah-mf-unity
changed the title
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change consistently adds the shared Unity-version notice to every rendered documentation page, with the navigation-only table of contents appropriately excluded. I verified the existing include convention, path resolution, and documentation-page coverage.
Reviewed commit be271ec
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## release/3.1 #1124 +/- ##
===============================================
+ Coverage 17.06% 22.73% +5.67%
===============================================
Files 209 243 +34
Lines 23769 28687 +4918
===============================================
+ Hits 4055 6523 +2468
- Misses 19714 22164 +2450
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -0,0 +1,2 @@ | |||
| > [!IMPORTANT] | |||
| > In Unity 6.6 and later, Cinemachine 3 isn't available in the Package Manager. The version of Cinemachine matches your Unity Editor version instead. No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| > In Unity 6.6 and later, Cinemachine 3 isn't available in the Package Manager. The version of Cinemachine matches your Unity Editor version instead. | |
| > In Unity 6.6 and later, Cinemachine 3 isn't available in the Package Manager. Use the Cinemachine version that matches your Unity Editor version instead. If your project already uses Cinemachine 3, you don't have to upgrade its content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Add message banner for status of Cinemachine 3 in Unity 6.6+.
JIRA: DOCG-9097