fix: add e-book MIME types - #6149
Open
PixelQuasar wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four e-book formats to the MIME table in
lib/API/Serve.js. They arecurrently absent, so
pm2 servelabels themtext/plain: browsers render thebytes instead of downloading the file, and readers that dispatch on
Content-Typedo not recognise it.Entries are inserted in the existing alphabetical order.
application/epub+zipis registered with IANA; the other three are the de facto values.
Purely additive — it only affects extensions that previously fell through to
the default, so nothing that works today changes. In particular the
text/plainfallback itself is untouched.
Verification
Ran the patched
Serve.jsdirectly, same way PM2 invokes it:The last two lines are the point: existing behaviour is unaffected.