Skip to content

GH#1667: cover mixed import queue cron cleanup#1672

Merged
superdav42 merged 1 commit into
mainfrom
feature/auto-20260724-122828-gh1667
Jul 24, 2026
Merged

GH#1667: cover mixed import queue cron cleanup#1672
superdav42 merged 1 commit into
mainfrom
feature/auto-20260724-122828-gh1667

Conversation

@superdav42

@superdav42 superdav42 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add mixed site/network import queue coverage for stale cron cleanup.
  • Verify the active queue keeps its scheduled hook while the inactive queue stale hook is removed.

Testing

  • php -l tests/WP_Ultimo/Site_Exporter_Test.php
  • vendor/bin/phpcs tests/WP_Ultimo/Site_Exporter_Test.php
  • vendor/bin/phpunit --filter 'WP_Ultimo\\Site_Exporter\\Site_Exporter_Test'

Runtime Testing

  • Self-assessed: low-risk test-only change.

Resolves #1667


aidevops.sh v3.32.180 plugin for OpenCode v1.18.4 with gpt-5.6-terra spent 2m and 50,001 tokens on this as a headless worker.

@superdav42 superdav42 added the origin:worker Auto-created by pulse labelless backfill (t2112) label Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@superdav42, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 39a5ca4a-9f91-425d-b141-e16418ad0db0

📥 Commits

Reviewing files that changed from the base of the PR and between 3701ff0 and 0b3a78c.

📒 Files selected for processing (1)
  • tests/WP_Ultimo/Site_Exporter_Test.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-20260724-122828-gh1667

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@superdav42
superdav42 force-pushed the feature/auto-20260724-122828-gh1667 branch from af9eb9f to 0b3a78c Compare July 24, 2026 18:33
@superdav42

superdav42 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Completion Summary

  • What: Added mixed queue-state coverage ensuring active import hooks persist while unrelated stale hooks are cleared.
  • Issue: Review followup: PR #1664 — fix: clear stale import cron events #1667
  • Files changed: tests/WP_Ultimo/Site_Exporter_Test.php
  • Testing: php -l tests/WP_Ultimo/Site_Exporter_Test.php (passed); PHPUnit unavailable because vendor dependencies and the local WordPress dev environment are absent.
  • Key decisions: Kept both mixed queue assertions with the existing stale-event regression test to cover the paired scheduling branches.

aidevops.sh v3.32.180 plugin for OpenCode v1.18.4 with gpt-5.6-terra spent 3m and 69,408 tokens on this as a headless worker.


Merged via PR #1672 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

@superdav42 superdav42 added the status:in-review PR open, awaiting review/merge label Jul 24, 2026
@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42
superdav42 marked this pull request as ready for review July 24, 2026 18:34
@superdav42
superdav42 merged commit 56eab5a into main Jul 24, 2026
11 checks passed
@superdav42 superdav42 added the review-feedback-scanned Merged PR already scanned for quality feedback label Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:worker Auto-created by pulse labelless backfill (t2112) review-feedback-scanned Merged PR already scanned for quality feedback status:in-review PR open, awaiting review/merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review followup: PR #1664 — fix: clear stale import cron events

1 participant