Skip to content

chore: add code quality checks - #59

Merged
superdav42 merged 1 commit into
masterfrom
feature/auto-20260922-195746
Sep 23, 2026
Merged

superdav42 merged 1 commit into
masterfrom
feature/auto-20260922-195746

Conversation

@superdav42

@superdav42 superdav42 commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add PHPCS with WordPress, WordPress Docs, and PHP compatibility standards
  • add PHPStan with WordPress and WooCommerce type information at an initial level 3 baseline
  • consolidate ESLint configuration and add reproducible lint scripts
  • add GitHub Actions checks for ESLint, production builds, PHPCS, and PHPStan
  • fix existing source and documentation defects exposed by the new quality gates

Implementation

  • Composer development tooling installs in the ignored vendor/ directory so the shipped lib/ autoloader remains unchanged.
  • PHPStan analyzes the plugin entry points and includes/, with a small Akismet stub for functions supplied by that optional plugin.
  • Existing PHP and JavaScript technical-debt findings remain visible as PHPCS/ESLint warnings; new lint and static-analysis errors fail CI.
  • Node tooling pins compatible Prettier and TypeScript versions for the repository's existing ESLint stack.

Verification

  • composer validate --strict
  • composer install --prefer-dist --no-progress --no-interaction
  • composer lint (PHPCS: 0 errors; PHPStan level 3: 0 errors)
  • npm ci --ignore-scripts
  • npm run lint:js (0 errors; existing warnings reported)
  • npm run build
  • PHP syntax checks for changed PHP files
  • npx prettier --check .github/workflows/code-quality.yml
  • npm audit --omit=dev (0 vulnerabilities)

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Ultimate-Multisite/simple-comment-editing/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: eea3ffd2-93bb-4187-8c3a-d4966a53006b

📥 Commits

Reviewing files that changed from the base of the PR and between 979b98a and 5597b35.

⛔ Files ignored due to path filters (2)
  • composer.lock is excluded by !**/*.lock
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (10)
  • .eslintrc
  • .eslintrc.json
  • .github/workflows/code-quality.yml
  • .gitignore
  • composer.json
  • includes/WooCommerce.php
  • js/simple-comment-editing.js
  • package.json
  • phpcs.xml.dist
  • simple-comment-editing.php
💤 Files with no reviewable changes (1)
  • .eslintrc

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates JavaScript and PHP quality tooling, adds automated GitHub Actions checks, and corrects a static method call, a timer calculation variable, and a PHPDoc parameter name.

Changes

Code quality tooling and source corrections

Layer / File(s) Summary
Quality tooling definitions
.eslintrc, .eslintrc.json, composer.json, package.json, phpcs.xml.dist, .gitignore
The JavaScript and PHP lint configurations, package scripts, development dependencies, PHPCS rules, and ignored paths are updated.
Source naming and static-call corrections
simple-comment-editing.php, js/simple-comment-editing.js, includes/WooCommerce.php
The static cookie-generation call uses the singleton instance. The timer calculation uses remaining_minutes. The PHPDoc parameter name matches the method signature.
Automated quality checks
.github/workflows/code-quality.yml
A workflow runs JavaScript build and lint checks and PHP coding-standard checks on pushes, pull requests, and manual dispatches targeting master.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant npm
  participant Composer
  GitHubActions->>npm: Install Node.js dependencies
  npm->>GitHubActions: Run ESLint and build
  GitHubActions->>Composer: Install PHP dependencies
  Composer->>GitHubActions: Run PHPCS
Loading

Merge Risk: ⚪ Minimal · up to 5597b

The new quality checks and source corrections have no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title, "chore: add code quality checks," accurately summarizes the primary changes, including ESLint, PHPCS, lint scripts, and CI workflow checks.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (6 skipped: 6 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@superdav42
superdav42 merged commit 8881a7a into master Sep 23, 2026
3 checks passed
@superdav42

Copy link
Copy Markdown
Collaborator Author

Summary

  • add PHPCS with WordPress, WordPress Docs, and PHP compatibility standards
  • consolidate ESLint configuration and add reproducible lint scripts
  • add GitHub Actions checks for ESLint, production builds, and PHPCS
  • fix three existing source issues that blocked the new quality gates

Implementation

  • Composer development tooling installs in the ignored vendor/ directory so the shipped lib/ autoloader remains unchanged.
  • Existing PHP and JavaScript technical-debt findings remain visible as warnings; new lint errors fail CI.
  • Node tooling pins compatible Prettier and TypeScript versions for the repository's existing ESLint stack.

Verification

  • composer validate --strict
  • composer install --prefer-dist --no-progress --no-interaction
  • composer phpcs (0 errors; existing warnings reported)
  • npm ci --ignore-scripts
  • npm run lint:js (0 errors; existing warnings reported)
  • npm run build
  • php -l includes/WooCommerce.php
  • php -l simple-comment-editing.php
  • npx prettier --check .github/workflows/code-quality.yml
  • npm audit --omit=dev (0 vulnerabilities)

aidevops.sh v3.34.13 plugin for OpenCode v1.18.31 with gpt-5.6-sol


Merged via PR #59 to master.
Merged by deterministic merge pass (pulse-wrapper.sh).

@superdav42 superdav42 added the review-feedback-scanned Merged PR already scanned for quality feedback label Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-feedback-scanned Merged PR already scanned for quality feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant