fix: attribute the js packages to UiPath and ship the client readme [HDENS-7797] - #161
Merged
Merged
Conversation
…HDENS-7797] Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
eduard-dumitru
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDENS-7797
Follow-up to #158 (repository/bugs/homepage) and #159 (LICENSE in the tarball). Two things were still wrong with what we publish:
authorwas"Eduard Dumitru"— the last personal attribution left on the packages.assets/<target>/README.md, so the registry page for@uipath/coreipcshowed a heading and nothing else. The actual JS client documentation lived insrc/Clients/js/README.mdand never shipped.What changed
src/Clients/js/package.json:"author": "UiPath". This file ispackageBaseforGeneratePackageJsonPlugin, so the value lands in both generated manifests without touching the prepack output.webpack.common.js: copyREADME.mdandreadme-assets/into each generated package, next to the LICENSE pattern fix: ship the MIT LICENSE inside both js packages #159 added.assets/*/README.mdone-liners — leaving them would make two copy patterns emit a differentREADME.mdto the same path.../../../README.md, the .NET README) is now the absolute repo URL, since nothing abovepackage/exists in a tarball. Thereadme-assets/images stay relative and now travel with the package.The same doc ships in both packages, on purpose
@uipath/coreipc-webis the browser build of the same client:src/stdplussrc/web, WebSockets only —isPipeexists only undersrc/node, so named pipes are genuinely Node-only. The doc is written for both (its package table lists both, and the usage examples show both import specifiers side by side, marking pipes "exclusive to Node.js"), so shipping one file keeps a single source of truth. A web reader still sees the pipe snippets; splitting the doc per target would be the alternative and seems worse than that.Verification
Built both packages locally (
npx webpack --config webpack.dev.js, exit 0, no asset conflicts) and inspected the tarballs it packed:uipath-coreipc-1.0.18.tgzanduipath-coreipc-web-1.0.18.tgzboth containpackage/README.md,package/readme-assets/*(5 images) andpackage/LICENSEpackage/README.mdis the client doc, starting at "# UiPath CoreIpc client for JavaScript""author": "UiPath","license": "MIT", and repository/bugs/homepage all onUiPath/coreipcBlast radius
Metadata and docs only — no client source, no version change. The tarball grows by ~53 KB of images. It takes effect at the next publish of the JS packages; versions already on GitHub Packages keep the old author and placeholder README.
Deliberately not in this PR
src/Clients/python/uipath-ipc/pyproject.toml:8still attributes an individual (authors = [{ name = "Eduard Dumitru", ... }]); same class of fix, different package."name": "coreipc"/"version": "1.0.18"while ADO publishes@uipath/coreipcat the csproj version; the ticket asks about that drift, and it is a separate change.🤖 Generated with Claude Code