[Content] Fix review validation for PDF-only registry entries - #140
Merged
Merged
Conversation
Review workflowPurpose: content · Classification: awaiting administrator assignment
Next: Administrator: classify this PR Completed stages persist until an administrator restarts them. Replies and resolved threads are not approval requirements. Use This PR has merged. Production deployment follows the main approval process. |
usace-rmc-docs-review
Bot
changed the title
usace-rmc-docs-review
Bot
added
purpose:content
stage:needs-lane
|
@USACE-RMC/docs-admin — classify this PR with |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review validation crashed on every PR because the shared registry includes legitimate PDF-only tiles without
doc_location. Skip those tiles when comparing MDX document identities and reject non-string document paths with a validation error.Added regression coverage for the actual registry, PDF-only and malformed entries, and invalid path types. All 48 review tests pass locally; the three new tests failed before the fix. This unblocks PR #139 once the trusted controller on main is updated.