Skip to content

Overhaul document review and draft publication workflows - #138

Merged
AdamGohs merged 2 commits into
mainfrom
ci/review-workflow-overhaul
Sep 9, 2026
Merged

AdamGohs merged 2 commits into
mainfrom
ci/review-workflow-overhaul

Conversation

@AdamGohs

@AdamGohs AdamGohs commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Allow new documents to merge and deploy as active drafts after content review, with Director review initiated separately. The Director uses a stable preview and full-document inline review PR; approval or administrator waiver creates a linked publication PR containing corrections and the selected draft-flag reversal. An administrator verifies and merges publication, then approves production deployment.

Unify all review lanes around administrator classification, one authoritative reviewer per stage, durable completion, explicit restart/waiver actions, and administrator role flexibility. Add protected review state, deduplicated handoffs, preview recovery/cleanup, main-only production, and updated author/reviewer guidance. Document attribution remains manual; no automatic reminders or separate notification infrastructure are added.

Document scope

Administrator infrastructure overhaul spanning GitHub workflows, review scripts, authoring helpers, the Documentation Guide, and GitHub workflow guidance. This is the implementation cutover, not a routine single-document author PR.

Validation

  • 45 automated tests passed.
  • Production site build passed.
  • All six workflow YAML files parsed; formatting and whitespace checks passed.
  • Offline dependency-install dry run passed.
  • Independent review findings addressed; detailed evidence is in the verification record.

Review notes

Activation requires a dedicated GitHub App, credentials in a main-only protected review-control environment, controller branch protections, required statuses bound to the App, and production environment restrictions. Follow the activation checklist. These settings have not been applied, and live end-to-end behavior has not been verified. No pilot, migration, merge, or deployment was performed.

GitHub users' native subscriptions and email preferences still control notifications from their own review conversations; the controller reduces its own automated notifications.

@AdamGohs
AdamGohs requested a review from a team as a code owner September 9, 2026 15:13
@AdamGohs
AdamGohs merged commit 3f78539 into main Sep 9, 2026
1 check passed
@AdamGohs
AdamGohs deleted the ci/review-workflow-overhaul branch September 9, 2026 15:24

This branch had an error being deployed

1 failed deployment
review-control — 7e547723 Deployed Sep 9, 2026 by AdamGohs via control #318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant