Skip to content

fix(ui5-date-picker): sync disabled state to inner input immediately on change #14019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unazko wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(ui5-date-picker): sync disabled state to inner input immediately on change #14019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/main/src/DatePicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ import datePickerCss from "./generated/themes/DatePicker.css.js";
import datePickerPopoverCss from "./generated/themes/DatePickerPopover.css.js";
import ResponsivePopoverCommonCss from "./generated/themes/ResponsivePopoverCommon.css.js";
import ValueStateMessageCss from "./generated/themes/ValueStateMessage.css.js";
import type { Slot } from "@ui5/webcomponents-base/dist/UI5Element.js";
import type { Slot, ChangeInfo } from "@ui5/webcomponents-base/dist/UI5Element.js";

type ValueStateAnnouncement = Record<Exclude<ValueState, ValueState.None>, string>;

Expand Down Expand Up @@ -485,6 +485,12 @@ class DatePicker extends DateComponentBase implements IFormInputElement {
this._calendarCurrentPicker = this.firstPicker;
}

onInvalidation(changeInfo: ChangeInfo) {
if (changeInfo.type === "property" && changeInfo.name === "disabled" && this._dateTimeInput) {
this._dateTimeInput.disabled = !!changeInfo.newValue;
}
}

onBeforeRendering() {
["minDate", "maxDate"].forEach((prop: string) => {
const propValue = this[prop as keyof DatePicker] as string;
Expand Down
Loading