Conversation
The previous FIXME suggested matching changed resources against the provided pattern. That would not address the underlying problem: a changed input source map (.js.map) does not re-minify its owning .js, leaving the produced -dbg.js.map stale. A real fix needs the task to learn the .map -> .js relation while processing changedProjectResourcePaths, which is likely a larger rework rather than a local change. Restate the FIXME accordingly.
…ource-map staleness
…l source-map staleness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two
test.failingintegration tests (build and serve) that pin down a differential-build gap: changing only a.js.mapinput source map invalidates minify's cache but does not re-minify its owning.js, so the produced-dbg.js.mapgoes stale.Also restates the misleading minify FIXME — a fix needs the task to learn the
.map->.jsrelation while processing changed resources, not a local pattern tweak.JIRA: CPOUI5FOUNDATION-1360