Add settings page and enforce 2FA flows - #822
Merged
Merged
Conversation
✅ Deploy Preview for ucmacm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No767
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds in the complete settings page, alongside proper enforcement of the two-factor authentication flows and setup of the 2fa. Note that the settings page is not a traditional route, but actually a masked one. It lives in
src/routes/dashboard/route.tsx, as it's a dialog that goes on top of whatever page you are. It's hosted by the/src/routes/dashboard/route.tsxcomponent as it is always mounted and then just goes to get it via a search param instead. It's masked to read it as/dashboard/settings. The routesrc/route/dashboard/settings.tsxactually just deep links it back to the dialog for your reference.The 2fa is also properly done, and tested. It actually works for once... This is probably one of the last major feature additions to the website I think. This is the farthest that the website has ever gotten. Even farthest than the Firebase version
Types of changes
What types of changes does your code introduce to the UC Merced's ACM Chapter Website?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply